docs: update Vuex guide for namespaced option #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmiller1990
reviewed
Jun 8, 2018
docs/guides/using-with-vuex.md
Outdated
| import Vuex from 'vuex' | ||
| import MyComponent from '../../../src/components/MyComponent' | ||
| import mymodule from '../../../src/store/mymodule' | ||
| import myModule from '../../../src/store/myModule' |
There was a problem hiding this comment.
I like this, fits the common convention of camel casing modules
docs/guides/using-with-vuex.md
Outdated
| @@ -241,10 +239,11 @@ describe('MyComponent.vue', () => { | |||
|
|
|||
| store = new Vuex.Store({ | |||
| modules: { | |||
| mymodule: { | |||
| myModule: { | |||
| namespaced: true, // If store/myModule is namespaced https://vuex.vuejs.org/guide/modules.html#namespacing | |||
There was a problem hiding this comment.
I don't think this is necessary. I think the examples should have as little noise as possible. Since the user is testing their modules, we can assume they know if they namespaced it or not. Since the focus of this guide and repo is the test setup/assertions, not Vuex and the Vuex API, I don't think this should be included.
|
Thanks for the PR, I agree with @lmiller1990 Could you also update the example repo to match your changes—https://github.com/eddyerburgh/vue-test-utils-vuex-example |
|
Updated based on comment, also there is a PR on the mentioned example repo to reflect changes. |
lmiller1990
approved these changes
Jun 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.